D11-11: Bump core version, and address some issues flagged by upgrade_status#169
D11-11: Bump core version, and address some issues flagged by upgrade_status#169adam-vessey wants to merge 8 commits intomainfrom
Conversation
Seems appropriate for now? Though, I suppose it is to be removed for Drush 14? Shrug?
📝 WalkthroughWalkthroughUpdates package constraints and Drupal core compatibility, adds select module dependencies, adjusts tests, and tightens PHP method signatures. One database helper switches from tablePrefix() to getPrefix(). No new features introduced. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
adam-vessey
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@composer.json`:
- Line 34: The current Composer platform config entry for
"drush.11-12.services.yml" uses an open-ended constraint ">=11.6"; update this
to a bounded version to avoid accidentally allowing incompatible Drush major
releases (e.g., change the constraint to ">=11.6,<14.0" or another agreed upper
bound) and document the chosen bound in a brief comment or commit message;
locate the key "drush.11-12.services.yml" in composer.json and replace the
version string accordingly, ensuring composer validate passes and running a
quick compatibility test (e.g., install or update) to confirm no regressions.
| "drush": { | ||
| "services": { | ||
| "drush.11-12.services.yml": "^11.6 || ^12", | ||
| "drush.11-12.services.yml": ">=11.6", |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Drush 13 release Drupal 11 compatibility
💡 Result:
- Drush 13.0.0 release date: August 2, 2024. [1]
- Drupal 11 compatibility: Yes — Drush 13 is marked as supported/recommended for Drupal 11 (and compatible with Drupal 10.2+). [2]
- Key requirement: Drush 13 requires PHP 8.3+. [2]
Sources:
[1] endoflife.date (Drush release timeline)
[2] Drush docs (Drupal compatibility table)
Revisit the open-ended Drush services constraint now that Drush 13 is released.
Drush 13 was released in August 2024 and is compatible with Drupal 11. The constraint >=11.6 does match Drush 13 as intended, but given the commit message indicated this was a "temporary/compatibility change," the constraint approach should be formally reassessed. Determine whether this open-ended constraint will remain appropriate for Drush 14+ or if it requires tightening to a specific upper bound (e.g., >=11.6,<14.0).
🤖 Prompt for AI Agents
In `@composer.json` at line 34, The current Composer platform config entry for
"drush.11-12.services.yml" uses an open-ended constraint ">=11.6"; update this
to a bounded version to avoid accidentally allowing incompatible Drush major
releases (e.g., change the constraint to ">=11.6,<14.0" or another agreed upper
bound) and document the chosen bound in a brief comment or commit message;
locate the key "drush.11-12.services.yml" in composer.json and replace the
version string accordingly, ensuring composer validate passes and running a
quick compatibility test (e.g., install or update) to confirm no regressions.
3 participants
Builds on #168
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.