Fix #63, updated SRT KM configuration #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (3)
- basie/user_templates/configuration.txt: Language not supported
- basie/user_templates/configuration_SR.txt: Language not supported
- basie/user_templates/targets.txt: Language not supported
Comments suppressed due to low confidence (2)
basie/radiotelescopes.py:109
- Verify that the updated feed offset values for index 1 match the SRT K band receiver specifications. If these values are correct, consider adding a brief inline comment to indicate the source or reason for the change.
SRT.receivers["KM"].set_feed_offsets(1, (VAngle(-0.00066710365, u.rad),
basie/radiotelescopes.py:128
- Ensure that the reordering of valid pairs corresponds precisely with the new feed offset indices. If the changes are intentional, adding a short comment explaining the rationale could improve maintainability.
'0': [(0,1),(0,4),(1,4),(2,3),(5,6)],
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the feeds offsets for the SRT K band multi feed receiver. The offsets now are the same as in discos.
I also updated the discos documentation and a PR is still open. Hope you can approve it and merge it soon.