Install rust in travis.yml for building NIF#14
Open
copperwall wants to merge 3 commits intodiscord:masterfrom
Open
Install rust in travis.yml for building NIF#14copperwall wants to merge 3 commits intodiscord:masterfrom
copperwall wants to merge 3 commits intodiscord:masterfrom
Conversation
This adds a before_install step to the travis.yml which downloads a rust toolchain for building the native/ directory in this repo. This doesn't use rust's stable channel because Rustler fails to build on stable.
Tests that have an explicit 240_000 second timeout are timing out in the CI environment. This bumps them to 320_000
copperwall
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a before_install step to the travis.yml which downloads
a rust toolchain for building the native/ directory in this repo.
This doesn't use rust's stable channel because Rustler fails to build on
stable.
Once the project started building in Travis, I noticed that some test cases were timing out due to long run times. I added a commit to increase those timeouts, since the CI environment might be a little slower than an internal test environment.
Lastly, I saw some unnecessary
mutwarnings in the Travis build log so I removed those as well.I'm a little new to Elixir so I understand if some of this isn't idiomatic. I'd be super happy for any feedback!