Conversation
8305670 to
d6d4bd3
Compare
nulltrope
approved these changes
Aug 26, 2024
nulltrope
left a comment
There was a problem hiding this comment.
LGTM, appreciate the detailed PR description & tests. Also nice we're upstreaming these fixes :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes changes in PR submitted to Piexif project: hMatoba#146
Description
This pull request addresses two key issues related to handling animated WebP files in the Piexif library:
Canvas Size Detection:
VP8Xchunk dimensions were incorrectly set based on the last frame encountered, which could result in canvas dimensions being too small when frames of varying sizes were present.VP8Xchunk accurately reflects the overall canvas size.Alpha Channel Detection for Animated Frames:
VP8Xchunk for animated WebP files whereALPHchunks were nested withinANMFchunks._get_sub_chunks_from_anmf, has been introduced to recursively examine sub-chunks withinANMFchunks while preventing excessive recursion through a depth limit.Testing