update bootloader to usedbytes' latest commits #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We observed strange issues that (among other things) revealed that make clean did not really make things as clean as it could. This is an attempt to clean up various files generated.
As ${APP_BIN} and ${APP_HDR_BIN} are not true targets, the dependency on them
effectively only required the .bin files to be present.
When building with make -j, this led to the situation that the target
${NAME}_hdr finished *before* compiling the project, in case there were .bin
files left from previous builds, leading to ${NAME}_hdr.bin files containing
invalid CRCs.
Setting the dependencies on ${NAME} fixes this issue. The reasoning is that if
target ${NAME} is built, ${APP_BIN} should have been generated. There is no
need to depend on both ${NAME} and ${NAME}_hdr, as ${NAME}_hdr already depends
on ${NAME}.
This should make it easier to modify offsets without breaking stuff. Various uses of IMAGE_HEADER_OFFSET could be simplified further. Deleted bootloader.ld and combined.ld, they are not used.
This allows to drop the nasty hardcoded address in CMakeLists.txt.
…p of the .app_bin section in the map file
I always forget what the PICO_BOARD bit needs to be, so just write it down.
CMakeLists.txt: let picowota_build_combined add files to clean target
CMakeLists.txt: fix dependencies to allow make -j
…into thingsconnected-pullreq3 Conflicts: CMakeLists.txt
Replace constant value for IMAGE_HEADER_OFFSET by linker supplied value
The dependencies should be between targets, not between commands and files. Target dependencies on commands are not what they seem to be, and don't work. Also see question, answer and comments on https://stackoverflow.com/questions/4010212/cmake-struggling-with-add-custom-command-dependencies
fix dependencies (again)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.