Skip to content

Random seeding#32

Open
rrseelam wants to merge 35 commits intomasterfrom
random_seeding
Open

Random seeding#32
rrseelam wants to merge 35 commits intomasterfrom
random_seeding

Conversation

@rrseelam
Copy link
Copy Markdown
Collaborator

@rrseelam rrseelam commented Jul 1, 2024

Implemented random seeding:

  • Each class involving randomness takes a random_seed parameter
  • By default, random_seed is set to 0. In this case, no seeding occurs

Copy link
Copy Markdown
Owner

@dipplestix dipplestix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, please tag me as a reviewer in the future.

For the seed, please default to None instead of 0 as the default parameter and get rid of the if statements

@rrseelam rrseelam requested a review from dipplestix August 1, 2024 02:31
@rrseelam
Copy link
Copy Markdown
Collaborator Author

rrseelam commented Aug 1, 2024

Changed the default seed to be None. torch didn't accept None as an input, so I used a value sampled from random instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants