Unit tests + source code restructure#7
Open
ShadenSmith wants to merge 10 commits intodionysio:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests via Python's
unittestframework. It accordingly moves the bulk of the sorting code tocsvsorter.pyand simply calls that function from the__init__.pyentrypoint.This also includes a fix for
heapq.merge()accepting akeyparameter for when a subset of columns are being sorted. Note: thekeyparameter was added in Python version 3.5, and so this will not work in older distributions.Note: I have not tested this code as a commandline utility -- maybe
setup.pyneeds to be edited as well? I have only touched it as a library.