Add support for proxy from extra_config #205
Conversation
Summary of ChangesHello @hansr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement to how proxy configurations are handled by allowing the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for retrieving the proxy_to address from the extra_config property as a fallback. The implementation is generally correct, but I've provided a suggestion to refactor a block of code in cmd/diode/join.go. The proposed change improves readability by reducing nesting and enhances robustness by adding error logging for JSON parsing, which was previously silent.
| extraRaw := strings.TrimSpace(props["extra_config"]) | ||
| if extraRaw != "" { | ||
| var extra map[string]interface{} | ||
| if err := json.Unmarshal([]byte(extraRaw), &extra); err == nil { | ||
| if val, ok := extra["proxy_to"]; ok && val != nil { | ||
| if str, ok := val.(string); ok { | ||
| proxyTo = strings.TrimSpace(str) | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
The logic to extract proxy_to from extra_config is quite nested and hard to read. Additionally, it silently ignores JSON parsing errors, which could hide issues with malformed extra_config data.
You can make this code more robust and readable by using a struct for JSON unmarshaling and logging any parsing errors. This simplifies the code and improves error handling.
extraRaw := strings.TrimSpace(props["extra_config"])
if extraRaw != "" {
var extra struct {
ProxyTo string "json:\"proxy_to\""
}
if err := json.Unmarshal([]byte(extraRaw), &extra); err != nil {
if cfg != nil && cfg.Logger != nil {
cfg.Logger.Warn("Failed to parse extra_config for proxy_to on contract %s: %v", current, err)
}
} else {
proxyTo = strings.TrimSpace(extra.ProxyTo)
}
}
|
We decided to go away from extra_config usage for commands. |
We need to support using extra_config also for proxy