Add configurable max ports per device limit via -maxports flag

[Copilot]

The hardcoded limit of 10 concurrent ports per device was insufficient for gateway deployments handling hundreds of simultaneous requests to domains like ddriveupdate.diode.link.

Changes

• Added -maxports flag to socksd, gateway, and publish commands (default: 10)
• Created Config.GetMaxPortsPerDevice() helper method
• Updated rate limiting in datapool.IncrementConnectionAttempt() and socks.doConnectDevice() to use configurable value
• Optimized by caching config lookups outside loops and synchronized calls
• Setting -maxports=0 disables rate limiting entirely (unlimited connections)

Usage

# Default behavior (10 ports per device)
diode gateway

# Gateway handling high traffic (unlimited)
diode gateway -maxports 0

# Custom limit for specific deployment
diode gateway -maxports 1000

# Conservative limit for testing
diode socksd -maxports 5

This allows operators to tune the limit based on deployment characteristics while maintaining safe defaults for typical use cases. Setting the value to 0 removes all rate limiting for high-traffic gateway deployments.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

---

Note

Adds a configurable per-device concurrent port limit via -maxports (0=unlimited) and uses it for connection rate limiting in SOCKS/datapool; flags added to gateway, publish, and socksd.

• Config/CLI:
  • Add cfg.MaxPortsPerDevice and Config.GetMaxPortsPerDevice() in config/flag.go.
  • Introduce -maxports flag (default 10, 0 = unlimited) in cmd/diode/gateway.go, cmd/diode/publish.go, and cmd/diode/socksd.go.
• RPC/Rate Limiting:
  • Update rpc/datapool.go IncrementConnectionAttempt() to enforce MaxPortsPerDevice across active and in-progress connections; prefetch config before lock.
  • Update rpc/socks.go doConnectDevice() to skip candidates when active ports reach MaxPortsPerDevice (cached config read outside loop).

^{Written by Cursor Bugbot for commit 594261c. This will update automatically on new commits. Configure here.}

[dominicletz]

@copilot Let's change the logic a little bit so that when specifying -maxports=0 it means "unlimited"

[Copilot]

@copilot Let's change the logic a little bit so that when specifying -maxports=0 it means "unlimited"

Done. Setting -maxports=0 now means unlimited (no rate limiting). The flag descriptions have been updated to indicate "(0 = unlimited)". Commit: 594261c

[cursor]

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

[cursor]

Bug: Inconsistent handling of negative maxports values blocks connections

The two rate limiting checks handle negative maxPorts values inconsistently. In socks.go, the condition maxPorts > 0 treats negative values as unlimited (skips rate limiting). However, in datapool.go, the condition maxPorts == 0 only matches exactly zero, so negative values fall through to activePorts+inProgressAttempts < maxPorts, which is always false when maxPorts is negative (since non-negative counts are never less than a negative number). This blocks all connection attempts when a negative value is passed. The datapool.go condition should use maxPorts <= 0 instead of maxPorts == 0 for consistency.

Additional Locations (1)

• rpc/socks.go#L350-L351