Improve CI pipeline #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrier989
force-pushed
the
fix/ci
branch
5 times, most recently
from
f148492 to
bfb508a
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the CI/CD pipeline to improve code quality checks and test coverage. The changes ensure both dart2js and dart2wasm compilers are tested, add package health analysis, and improve code formatting consistency across the codebase.
- Adds dart2wasm compatibility fix for browser tests
- Introduces comprehensive CI improvements including package health checks with pana
- Applies consistent code formatting across multiple files
Reviewed Changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/dart.yml | Adds package health job with pana, splits Chrome tests to test both dart2js and dart2wasm compilers, adds SDK version matrix to test job, and improves job naming |
| CHANGELOG.md | Adds entry for version 2.3.1 |
| pubspec.yaml | Bumps version to 2.3.1 |
| test/platform_test.dart | Adds dart:js_interop import and .toDart conversion for dart2wasm compatibility |
| dart_test.yaml | Removes node platform and ipv6 tags configuration |
| lib/io.dart | Adds @nodoc documentation annotation |
| lib/src/*.dart | Applies consistent code formatting and alignment across multiple source files |
| test/http_client_test.dart | Applies consistent code formatting to test functions and type definitions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.