Load all the objects by stepping the webservice repeatedly.#5
Open
runephilosof wants to merge 2 commits intoding2:masterfrom
Open
Load all the objects by stepping the webservice repeatedly.#5runephilosof wants to merge 2 commits intoding2:masterfrom
runephilosof wants to merge 2 commits intoding2:masterfrom
Conversation
Yes, this will be slow for large lists! We might consider inserting a pager in the frontend. But it is nicer than the current loan lists missing some titles when the limit of 50 uncached objects are hit. opensearch limits stepValue to 50 (even though it doesn't say so in the documentation)...
Member
|
Nice catch! Could you please add a sprinkle of code comments? It is very important that we explain the reasoning behind such workarounds. |
Contributor
Author
|
@kasperg there you go. Let me know if it still isn't spicy enough. |
Member
|
I have pulled this PR into ding2tal as i ran into the same problem, hence this PR will be part of a larger PR from ding2tal as well. |
cableman
added a commit
that referenced
this pull request
Sep 26, 2014
Send smaller requests to avoid breaking opensearch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yes, this will be slow for large lists! We might consider inserting a pager in the frontend.
But it is nicer than the current loan lists missing some titles when the limit of 50 uncached objects are hit.
opensearch limits stepValue to 50 (even though it doesn't say so in the documentation)...