Issue #287 by Inlead: Rewrite ding campaign module.#16
Merged
kasperg merged 46 commits intoding2:masterfrom Oct 29, 2015
Merged
Issue #287 by Inlead: Rewrite ding campaign module.#16kasperg merged 46 commits intoding2:masterfrom
kasperg merged 46 commits intoding2:masterfrom
Conversation
Signed-off-by: Martin Cording <guddo@me.com>
Signed-off-by: Martin Cording <guddo@me.com>
Signed-off-by: Martin Cording <guddo@me.com>
Signed-off-by: Martin Cording <guddo@me.com>
Signed-off-by: Martin Cording <guddo@me.com>
Signed-off-by: Martin Cording <guddo@me.com>
Member
There was a problem hiding this comment.
I would appreciate a comment describing why it is necessary to clear the cache at this point.
Member
|
@guddo: I have reviewed this. In general things look great. I have a request for an inline comment and a version should be adjusted as well. |
guddo
force-pushed
the
easyddb
branch
2 times, most recently
from
018bdbf to
1c65ef8
Compare
Member
There was a problem hiding this comment.
Please remove versioning information from the module.
Member
Author
There was a problem hiding this comment.
Sorry, this is a PR directly from our distribution - feel free to fork our repo or duplicate a PR like this.
Member
|
Merged. Thanks. |
kasperg
added a commit
that referenced
this pull request
Oct 29, 2015
Issue #287 by Inlead: Rewrite ding campaign module.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://platform.dandigbib.org/issues/287