DDBEASY-116 - Refactored the availability and reservable logic.#15
Closed
guddo wants to merge 14 commits intoding2:masterfrom
Closed
DDBEASY-116 - Refactored the availability and reservable logic.#15guddo wants to merge 14 commits intoding2:masterfrom
guddo wants to merge 14 commits intoding2:masterfrom
Conversation
Signed-off-by: Martin Cording <guddo@me.com>
Signed-off-by: Martin Cording <guddo@me.com>
Signed-off-by: Martin Cording <guddo@me.com>
…vable. Signed-off-by: Martin Cording <guddo@me.com>
Signed-off-by: Martin Cording <guddo@me.com>
Signed-off-by: Martin Cording <guddo@me.com>
Member
There was a problem hiding this comment.
This change should not be a part of the pull request.
Member
Author
Member
There was a problem hiding this comment.
Why add the not-reservable class to an element which we do not know the status for?
If we are to add a class I would expect it that we should add it to the element as well as in the other branches of the code.
Member
|
Review complete. Well done regarding the refactoring of the availability logic. This pull request contains more changes than has been approved for the next release and thus I cannot approve it without further consent from the product owners. |
Member
|
Also: Please rebase this pull request. It is no longer a trivial merge. |
Member
Author
|
Here you go: #16. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://platform.dandigbib.org/issues/618