-
Notifications
You must be signed in to change notification settings - Fork 0
Library conversion, Project Rename (DpsAuthApi) #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pauldps
wants to merge
125
commits into
main
Choose a base branch
from
library-conversion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verage and maintenance
…rverConfig and simplifying integration test setup
… to skip sensitive parameters
Pending: session object
- Changed the permissions field in the Role model from a JSON string to a Vec<String> for direct access. - Updated all resolvers, queries, and tests to reflect the new permissions structure. - Removed the permissions() method and replaced it with direct access to the permissions field. - Added a helper method to deserialize permissions from JSON when fetching roles from the database. - Ensured all tests are updated to validate the new permissions handling.
- Updated `AuthMeResponse`, `AuthRegisterResponse`, `UserDetailsResponse`, and `UserListing` to use `UserRole` struct for role information instead of separate role ID and name fields. - Introduced `UserWithRoleResponse` to encapsulate user details along with role information in registration responses. - Modified database queries to fetch role permissions and structured role data. - Updated tests to reflect changes in the GraphQL schema and response structures. - Added new query `GetUserByNameWithRoleQuery` to retrieve user details along with role information by username. - Ensured all relevant services and orchestrators are updated to handle the new role structure.
- Replaced direct SQL insertions with utility functions for creating test roles and users across multiple resolvers. - Updated tests in `add_site`, `auth_change_password`, `remove_role`, `remove_site`, `role`, `roles`, `update_role`, and `update_site` to use the new utility functions for better readability and maintainability. - Ensured that roles are created with appropriate permissions for each test case, improving the clarity of test setups.
…ce for cookie management
…d names and structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.