Skip to content

Upgrade GitHub Actions to latest versions #1567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
salmanmkc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade GitHub Actions to latest versions #1567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/actions/docker-build/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,22 +32,22 @@ runs:

- uses: actions/checkout@v4

- uses: docker/login-action@v3
- uses: docker/login-action@v4
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ github.token }}

- uses: crazy-max/ghaction-github-runtime@v3
- uses: crazy-max/ghaction-github-runtime@v4

- uses: docker/setup-buildx-action@v3
- uses: docker/setup-buildx-action@v4
with:
driver: docker-container
install: true
use: true
Comment on lines 45 to 47
Copy link
Contributor

@greptile-apps greptile-apps bot Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

install input removed in v4

The docker/setup-buildx-action@v4 removed the deprecated install input (see PR #464 in the setup-buildx-action repo). The PR description even notes this as a breaking change and states it "has been cleaned up from the workflow," but install: true is still present here. Other projects upgrading to v4 have confirmed the warning: Unexpected input(s) 'install', valid inputs are ['version', 'driver', 'driver-opts', 'buildkitd-flags', 'buildkitd-config', 'buildkitd-config-inline', 'use', 'name', 'endpoint', 'platforms', 'append', 'keep-state', 'cache-binary', 'cleanup'].

While GitHub Actions won't fail on unknown inputs, the install flag is now silently ignored, so buildx may not be installed as the default docker build command, which could change build behavior.

This same issue exists in all three files that use docker/setup-buildx-action@v4:

  • .github/actions/docker-build/action.yml:46
  • .github/workflows/_docker-build-template.yml:135
  • .github/workflows/docker.yml:177
Suggested change
driver: docker-container
install: true
use: true
use: true


- name: Build & Push ${{ inputs.target }}
uses: docker/build-push-action@v6
uses: docker/build-push-action@v7
with:
push: true
context: ${{ inputs.context }}
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/_docker-build-template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,26 +116,26 @@ jobs:

echo -e "post cleanup space:\n $(df -h)"

- uses: docker/login-action@v3
- uses: docker/login-action@v4
if: ${{ inputs.should-run }}
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

# required for github cache of docker layers
- uses: crazy-max/ghaction-github-runtime@v3
- uses: crazy-max/ghaction-github-runtime@v4
if: ${{ inputs.should-run }}

# required for github cache of docker layers
- uses: docker/setup-buildx-action@v3
- uses: docker/setup-buildx-action@v4
if: ${{ inputs.should-run }}
with:
driver: docker-container
install: true
use: true

- uses: docker/build-push-action@v6
- uses: docker/build-push-action@v7
if: ${{ inputs.should-run }}
with:
push: true
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/code-cleanup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:

- uses: actions/checkout@v3
- uses: actions/setup-python@v3
- uses: astral-sh/setup-uv@v4
- uses: astral-sh/setup-uv@v7
- name: Run pre-commit
id: pre-commit-first
uses: pre-commit/action@v3.0.1
Expand All @@ -32,6 +32,6 @@ jobs:
continue-on-error: false

- name: Commit code changes
uses: stefanzweifel/git-auto-commit-action@v5
uses: stefanzweifel/git-auto-commit-action@v7
with:
commit_message: "CI code cleanup"
10 changes: 5 additions & 5 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:

- uses: actions/checkout@v4
- id: filter
uses: dorny/paths-filter@v3
uses: dorny/paths-filter@v4
with:
base: ${{ github.event.before }}
filters: |
Expand Down Expand Up @@ -163,21 +163,21 @@ jobs:
lfs: false
token: ${{ secrets.NAV_REPO_READ_TOKEN }}

- uses: docker/login-action@v3
- uses: docker/login-action@v4
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- uses: crazy-max/ghaction-github-runtime@v3
- uses: crazy-max/ghaction-github-runtime@v4

- uses: docker/setup-buildx-action@v3
- uses: docker/setup-buildx-action@v4
with:
driver: docker-container
install: true
use: true

- uses: docker/build-push-action@v6
- uses: docker/build-push-action@v7
with:
push: true
context: .
Expand Down