-
Notifications
You must be signed in to change notification settings - Fork 154
Use G1 WebRTC camera in headless setup #1553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kaiknower
wants to merge
9
commits into
dimensionalOS:dev
Choose a base branch
from
kaiknower:fix-g1-headless-camera
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+53
−39
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3b46344
Merge pull request #1056 from dimensionalOS/dev - Pre-Release v0.0.8:…
spomichter e4defcb
Merge pull request #1092 - v0.0.9 Release Patch: Git clone change to …
spomichter 8e0f31a
Merge pull request #1336 from dimensionalOS/dev
spomichter 593a7f3
Merge pull request #1340 from dimensionalOS/dev
spomichter 8cf89e3
Merge pull request #1526 from dimensionalOS/dev
spomichter 0071ccd
Merge pull request #1530 from dimensionalOS/dev
spomichter 24c6c58
Merge pull request #1532 from dimensionalOS/dev
spomichter d6df62d
Merge pull request #1537 from dimensionalOS/dev
spomichter d620ace
Use G1 WebRTC camera in headless setup
kaiknower File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Class-level mutable default is shared across instances
_camera_info_static()is called once at class-definition time, so everyG1Connectioninstance shares the sameCameraInfoobject. This is safe today becausewith_ts()returns a new copy and the static object is never mutated, but it's a subtle footgun if the object is ever modified in-place later. For comparison,G1SimConnectionreads camera info at runtime fromself.connection.camera_info_static.Consider initializing this in
__init__instead:And then in
__init__, addself.camera_info_static = _camera_info_static().