Throw error if running ratpoison fails, and do not divide by zero#4
Open
horgh wants to merge 2 commits intodimatura:masterfrom
Open
Throw error if running ratpoison fails, and do not divide by zero#4horgh wants to merge 2 commits intodimatura:masterfrom
horgh wants to merge 2 commits intodimatura:masterfrom
Conversation
I encountered the second when I did not have ratpoison in my PATH.
I did not have ratpoison in my PATH. rpbar was starting up (once I fixed the divide by zero issue), but showing nothing but the foreground colour. This will make it clearer what the problem is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was running ratpoison from git and did not have it in my PATH, and rpbar was not running as expected. When I started ratpoison with rpbar listed to exec, rpbar would immediately crash. I found we were dividing by zero (the second case changed here). After fixing this rpbar would not crash, but did not show anything. I eventually figured out we were failing to call ratpoison because of my PATH mistake.
These changes hopefully will make figuring that out a little easier if something similar happens to anyone else!