Implement a dark mode switch #386
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/dimaip/calendar/g76ae3da9 |
mahsaandreeva
changed the title
mahsaandreeva
changed the title
dimaip
requested changes
Jan 4, 2021
Owner
There was a problem hiding this comment.
Wow, nice work!
A few things:
- by default the theme mode should be set according to user's system preference, the theme switch should only override that value when toggled
- let's put the theme switch in here and call it "Оформление" or "Внешний вид"
Alternatively we could put it as an extra menu item here:
Owner
|
Also the theme toggle has got to look good, e.g. check that of Github:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.