Proof-of-concept. Get audio levels data from StreamPack in a better way#272
Open
Proof-of-concept. Get audio levels data from StreamPack in a better way#272
Conversation
… before launching the coroutine The problem was that ByteBuffer.duplicate() only creates a new view over the same native memory - it doesn't actually copy the bytes. When the original DirectByteBuffer was returned to the pool and freed, both the original and the "duplicate" became invalid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a Git issue in StreamPack repo ThibaultBee/StreamPack#39 about adding VU meters aka audio levels support to StreamPack.
This PR is to see if idea from ThibaultBee/StreamPack#278 is feasible.
I put changes from the branch
feature/custom_audio_effectsfrom that PR on top of my StreamPack forkupdate-to-3.1.0, resolved merge conflicts and put it on a branchupdate-to-3.1.0+feature/custom_audio_effects.I only had to make a small adjustment on top of StreamPack in commit dimadesu/StreamPack@9671a9d to get it to work.
I can build project fine.
I can see audio levels working in the app as expected.