Open
Conversation
src/main/java/inventorysetups/ui/InventorySetupsAdditionalItemsPanel.java
Outdated
Show resolved
Hide resolved
ItemManager problems
Dragonkiller93
changed the title
Author
|
Lots of changes, thank you for all the help, and sorry so much was needed, still new to plugins. Should work across the board, but I did change a bit of logic that might need looking at. |
Dragonkiller93
commented
Jul 19, 2025
Dragonkiller93
changed the title
Owner
|
Looking better, more comments. |
Owner
dillydill123
left a comment
dillydill123
left a comment
There was a problem hiding this comment.
Looking better! More comments
| inventorySetup.getEquipment().forEach(toggleFuzzyIfMatched); | ||
| inventorySetup.getAdditionalFilteredItems().values().forEach(toggleFuzzyIfMatched); | ||
|
|
||
| if (inventorySetup.getQuiver() != null) |
Owner
There was a problem hiding this comment.
I think you need to also consider the bolt pouch and rune pouch. The InventorySetup needs a nicer/extendable interface for "Containers" but that's a different problem
| int processedId = itemManager.canonicalize(originalItem.getId()); | ||
| int baseProcessedId = InventorySetupsVariationMapping.map(processedId); | ||
| Collection<Integer> variations = InventorySetupsVariationMapping.getVariations(baseProcessedId); | ||
| variations.add(processedId); |
Owner
There was a problem hiding this comment.
Why do you need to add the processedId here? Shouldn't variations contain it already?
| plugin.toggleAllFuzzyOnSlot(slot); | ||
| }); | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an option to fuzzy all, which will make all items of the same type fuzzy/nonfuzzy, but only in the one setup. Ironically, the toggle all fuzzy is not fuzzy, so it will only work for items which are exactly the same.
Wording probably needs to be changed, not sure how the menu option should be setup.
Maybe a separate category of multiple item changers would be helpful. Similar to how shift changes all items across all setups, but only for the current setup. Could use ctrl instead of shift, and add this fuzzy toggle and a change all items option.
Fixes #267