Fix MinIO health check by using docker run instead of services #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MinIO service container was failing because GitHub Actions services don't support specifying a command for the container. The MinIO Docker image requires 'server /data' to be passed as arguments. Changed from using GitHub Actions services to starting MinIO manually with 'docker run' which allows passing the full command including 'server /data --console-address ":9001"'. Also improved error handling to show container logs if startup fails. Co-authored-by: dillonwilliams <1835005+dillonwilliams@users.noreply.github.com>
Co-authored-by: dillonwilliams <1835005+dillonwilliams@users.noreply.github.com>
Update actions/download-artifact from @v4 to @v4.1.7 to address the Arbitrary File Write via artifact extraction vulnerability (affects >= 4.0.0, < 4.1.3). Co-authored-by: dillonwilliams <1835005+dillonwilliams@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix MinIO health check issues in latest PR
Fix MinIO health check by using docker run instead of services
Jan 11, 2026
Owner
|
@copilot test script is undefined |
The workflow was calling `pnpm test` but no test script was defined, causing the workflow to fail with "Missing script: test". Added a placeholder test script that outputs a message until actual Playwright tests are implemented. Co-authored-by: dillonwilliams <1835005+dillonwilliams@users.noreply.github.com>
Author
Owner
|
@copilot the changes for minio here need to be on top of branch claude/fix-s5cmd-gui-builds-QBqXz |
Author
I'm unable to rebase this branch onto You could either: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
servercommand.github/workflows/build.ymlfile with the fixSummary
servicesto manualdocker runwith the correct command (server /data --console-address ":9001")Security Summary
actions/download-artifactfrom@v4to@v4.1.7to address the Arbitrary File Write vulnerabilityOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.