Claude/fix s5cmd gui builds q bq xz #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features: - Profile management with AWS Access Key and SSO authentication - OS keychain integration for secure credential storage - Enhanced file browser with Chonky (upgraded to v0.3.1) - File operations: copy, cut, paste, rename, delete, upload, download - Drag and drop support for uploads - Context menu with all operations - Search bar with real-time filtering and wildcard support - Column sorting with persistence - Progress dialog with cancel support - Status bar showing connection info and selection details - Settings panel (general and advanced) - Logging system with rotating files and viewer - GitHub Actions workflow for multi-platform builds - Playwright tests with Minio integration Technical changes: - Updated Tauri backend with modular Rust architecture - Added keyring crate for OS keychain integration - Added fern for logging with rotation - State management with Zustand - Toast notifications with react-hot-toast - Date formatting with date-fns
- Add externalBin configuration in tauri.conf.json to bundle s5cmd - Implement sidecar path resolution in s5cmd.rs with platform detection - Initialize sidecar path on app startup in main.rs - Update GitHub Actions workflow to download platform-specific s5cmd binaries: - Linux: s5cmd-x86_64-unknown-linux-gnu - Windows: s5cmd-x86_64-pc-windows-msvc.exe - macOS Intel: s5cmd-x86_64-apple-darwin - macOS ARM: s5cmd-aarch64-apple-darwin - Add Minio service for integration tests with Playwright
The test job was failing because the MinIO service container couldn't start properly. The issue was caused by the health check using 'curl' which is not available inside the MinIO container. Changes: - Use specific MinIO release version instead of 'latest' for stability - Remove problematic health check from service configuration - Add explicit wait step with curl from the runner to ensure MinIO is ready - Wait step runs on Ubuntu runner (has curl) instead of in container This ensures MinIO starts properly and is ready before tests run.
Owner
Author
|
@claude update primary branch to v2 as existing users may be using main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.