Open
Conversation
…in order to connect the editor with the packages that pyodide has available, also added loading packages and executing using loadPackagesFromImports(codeString), an inbuilt pyodide function
…rder to run the load package files. Change path back to local public directory
…er to add them (more description on how to in the README)
| } | ||
| }); | ||
|
|
||
| try{ |
Owner
There was a problem hiding this comment.
Code style: Needs space between try and opening curly brace
| }); | ||
|
|
||
| try{ | ||
| // load from specific URL from Pyodide - if integrity issues check that correct version and correct URL |
Owner
There was a problem hiding this comment.
Code style: Capitalise first word of comments
| // load from specific URL from Pyodide - if integrity issues check that correct version and correct URL | ||
| await pyodideInstance.loadPackagesFromImports(codeString); | ||
| } catch (e) { | ||
| let outputLine = e.message; // if fails do not run the code, output the error |
Owner
There was a problem hiding this comment.
Code style: Capitalise first word of comments
Owner
dillondesilva
left a comment
dillondesilva
left a comment
There was a problem hiding this comment.
Minor styling issues but otherwises LGTM👍🏽
dillondesilva
approved these changes
Jun 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made it so that packages can be imported into the python code. Also made a note for users in the markdown - might want to make clearer? Basically just saying if they want packages to be available when they create their own pyodide instance with a custom folder path, that folder must contain the packages they want in a .whl file.