Open
Conversation
ignore jupyter files
Collaborator
|
Great that you got it working. What was the issue? Could you report the differences between the results of the backends as an issue (maybe with a small-ish dataset)? That should definitely be looked into. There is problem with tuning thresholds with the OpenCL backend, which makes it perform much slower than it should. I am currently looking into that. Our experiments show that up to 5x speedup can be possible. We are currently not interested in the cupy backend. |
Author
|
The dataset is a SEPAL time series over Gabon so it cannot be used as it is. I'll try to cut it into smaller pieces to find a small dataset |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I managed to get the openCL backend to work but I was missing a simple GPU implementation to compare the performances of your implementation with a simple GPU backend.
I also tested the GPU openCL implementation over large datasets in central Africa and in some countries the Python Backend was giving better results, even though it was slower.
Based on the
numpyimplementation I created this backend using thecupylib (numpyfor GPU).As you may understand all the modification I made to the
numpybackend are the same as in thisone (asCupyis less tolerant thanNumpy). It is curently only 3% slower than the OpenCL implementation available in the develop branch and it's way easier to maintain.It could be useful for you as an alternative backend and eventually as a reference GPU implementation for further publications.
I'm working on it in the master branch of my fork but I think I can actually merge the
NumpyandCupyimplementation using a simple lazy import.Let me know if you think it's interesting. As long as we are experiencing bugs with openCL implementation, this backend will become the reference backend in the bfast-gpu application of SEPAL.