Skip to content

Action#query_keys accepts an array #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pnomolos wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Action#query_keys accepts an array #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/resource_kit/action.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def path(path = nil, &block)

def query_keys(*keys)
return @query_keys if keys.empty?
@query_keys += keys
@query_keys += keys.flatten
end

def handlers
Expand Down
7 changes: 6 additions & 1 deletion spec/lib/resource_kit/action_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,11 @@
action.query_keys :per_page, :page
expect(action.query_keys).to include(:per_page, :page)
end

it "allows setting known query parameters as an array" do
action.query_keys [:per_page, :page]
expect(action.query_keys).to include(:per_page, :page)
end
end

describe '#before_request' do
Expand All @@ -84,4 +89,4 @@
end
end
end
end
end