Skip to content

Connection factory #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bobbytables wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Connection factory #11

bobbytables wants to merge 5 commits into from

Conversation

@bobbytables
Copy link
Contributor

@bobbytables bobbytables commented Nov 3, 2014

This is a start to having:

  • Default connection builder! This addresses Default Connection Factory #6 and allows you to specify how a connection is built, removing the need to always pass in a connection.
  • Singleton behavior! You can now mix-in ResourceKit::SingletonResources to gain your actions on the class level. It will define the method on demand to prevent slow method_missing calls every time.

@bobbytables
Copy link
Contributor Author

bobbytables commented Nov 3, 2014

The duplication behavior on resources collection I hate, but it was the only way I could make the inheritance test past. We'll need to look into it. Inheriting DSL's is hard. 💩

@vjustov
Copy link
Contributor

vjustov commented Aug 6, 2015

Hello, why hasn't this been merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@violethaze74 violethaze74 violethaze74 approved these changes

@Ashleycho35 Ashleycho35 Ashleycho35 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bobbytables @vjustov @violethaze74 @Ashleycho35