GATEWAYS-4422 - Add DumpPortMappings API to retrieve ofport and MAC address for tap interfaces#141
Conversation
24eb418 to
7a2a409
Compare
23a13d6 to
9668b0a
Compare
|
Squashed into a single commit.
|
9668b0a to
823eec1
Compare
823eec1 to
55954bd
Compare
| // 'ovs-ofctl show': | ||
| // | ||
| // 7(interface1): addr:fe:4f:76:09:88:2b | ||
| func (p *PortMapping) UnmarshalText(b []byte) error { |
There was a problem hiding this comment.
wouldn't a regex be much nicer for this?
There was a problem hiding this comment.
We did move from regexp
#141 (comment)
I did observe the existing code (table, flow, PortStats all use strings)
There was a problem hiding this comment.
Github links to comments that have been resolved don't show what you are trying to link. Could you quote the thread you're referencing?
There was a problem hiding this comment.
Could you follow semantics similar to parseEach() and define your own parseEachPort() or something like that, instead of regexp?
showPrefix =[]byte("OFPT_FEATURES_REPLY")
|
@jcooperdo when you have time... ty! |
|
Converted this PR to a draft. After discussing with the team, we've decided to use the existing ovs-ofctl dump-ports approach (same method used by hvflowd) instead of implementing a new API with ovs-ofctl show. |
JIRA Ticket: https://do-internal.atlassian.net/browse/GATEWAYS-4422