Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ The `internalRelease.sh` script can also be run with a `--test` flag, in which c

### Testing changes locally

To test changes locally
To test changes locally. make sure to add --ignore-scripts flag during install.

```
npm install
npm install --ignore-scripts
npm run build
```
after which the deployer shell can be run as `/path/to/repo/bin/run`. It is often convenient to make a symbolic link in your path pointing to that location (e.g. as `dosls`). Then, you can test with
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@digitalocean/functions-deployer",
"version": "5.0.22",
"version": "5.0.23",
"description": "The the functions deployer for DigitalOcean",
"main": "lib/index.js",
"repository": {
Expand Down
4 changes: 2 additions & 2 deletions scripts/packageDosls.sh

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please share the ticket/context of the security ticket

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have any ticket for this. It came as an announcement mail. Added more context in the PR description.

Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ echo "- Removing old artifacts"
rm -rf lib node_modules *.tgz dosls

echo "- Ensuring a full install"
npm install --silent --no-progress
npm install --ignore-scripts --silent --no-progress

echo "- Building the simple tarball"
npm pack
Expand All @@ -27,7 +27,7 @@ echo "- Creating node_modules for the full install"
mkdir dosls
cd dosls
cp ../package.json .
npm install --production --silent --no-progress ../$TARBALL_NAME
npm install --ignore-scripts --production --silent --no-progress ../$TARBALL_NAME
rm *.json

echo "- Downloading node binary suitable for runtime use"
Expand Down
4 changes: 2 additions & 2 deletions scripts/packageSandbox.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ echo "- Removing old artifacts"
rm -rf sandbox *.tar.gz digitalocean-functions-deployer-*.tgz node_modules

echo "- Building the simple deployer tarball"
npm install
npm install --ignore-scripts
npm pack

echo "- Moving artifacts to the sandbox folder"
Expand All @@ -31,7 +31,7 @@ fi

echo "$VERSION" > version
echo "- Installing production dependencies"
npm install --production
npm install --ignore-scripts --production

cd ..
echo "- Creating tar file $TARBALL_NAME"
Expand Down
6 changes: 3 additions & 3 deletions src/finder-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1396,8 +1396,8 @@ function npmBuilder(
const cmd = flags.yarn ? 'yarn' : 'npm';
const npmRunBuild = buildScriptExists(filepath);
const args = npmRunBuild
? ['install', '&&', cmd, 'run', 'build']
: ['install', '--production'];
? ['install', '--ignore-scripts', '&&', cmd, 'run', 'build']
: ['install', '--ignore-scripts', '--production'];
const infoMsg = [cmd, ...args].join(' ');
if (flags.incremental) {
debug('Detected incremental build');
Expand All @@ -1424,7 +1424,7 @@ function npmBuilder(
filepath,
displayPath,
infoMsg,
`${cmd} install`,
`${cmd} install --ignore-scripts`,
flags.verboseBuild,
buildEnv,
slice,
Expand Down
2 changes: 1 addition & 1 deletion src/version.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
// DO NOT EDIT MANUALLY
////////////////////////////////////////////////////////////////

export const version = '5.0.22';
export const version = '5.0.23';
Loading