Skip to content

fix: remote-build for python, php and nodejs #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sanpj2292 wants to merge 2 commits into from
Closed

fix: remote-build for python, php and nodejs #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d45bef7
fix: remote-build for python, php and nodejs
sanpj2292 Jul 23, 2025
e59c2e2
fix: potential e2e test issue
sanpj2292 Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion e2e/test_helper.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,14 @@ delete_package() {
init_namespace() {
$DOCTL auth init --access-token $DO_API_KEY
$DOCTL sls install
$DOCTL sls connect $TEST_NAMESPACE

# Check if namespace exists, create if it doesn't
if ! $DOCTL sls connect $TEST_NAMESPACE 2>/dev/null; then
echo "Namespace $TEST_NAMESPACE not found, creating it..."
$DOCTL sls namespaces create --label $TEST_NAMESPACE --region nyc1
sleep 10 # Wait for namespace to be ready
$DOCTL sls connect $TEST_NAMESPACE
fi

CREDS=$($DOCTL sls status --credentials)
export API_HOST=$(echo "$CREDS" | jq -r .APIHost)
Expand Down
10 changes: 6 additions & 4 deletions src/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,16 +224,18 @@ function locateBuild(
remoteRequired: boolean,
localRequired: boolean
) {
// Check for explicit remote build requests first (--remote-build flag or remoteBuild: true)
if (remoteRequired || (remoteRequested && !localRequired)) {
return 'remote';
}
if (!isRealBuild(buildField)) {
// Not a real build. Check remote-default conditions.
if (defaultRemote && !localRequired) {
return 'remote-default';
} // else does not meet remote-default conditions
return buildField;
} // else it's a real build. Check conditions for remote.
if (remoteRequired || (remoteRequested && !localRequired)) {
return 'remote';
} // else does not meet conditions for remote
}
// else does not meet conditions for remote
return buildField;
}

Expand Down
Loading