Do not merge: HA default true for cluster create#1812
Draft
pyadagiri-do wants to merge 6 commits intodigitalocean:mainfrom
Draft
Do not merge: HA default true for cluster create#1812pyadagiri-do wants to merge 6 commits intodigitalocean:mainfrom
pyadagiri-do wants to merge 6 commits intodigitalocean:mainfrom
Conversation
pyadagiri-do
changed the title
pyadagiri-do
force-pushed
the
pyadagiri/ha
branch
from
fb030da to
c78b48d
Compare
- Integration: test HA defaults to true when --ha is omitted - Integration: test HA disabled when --ha=false - Commands: add unit test for HA default in cluster create request
pyadagiri-do
changed the title
| expect.Equal(strings.TrimSpace(fmt.Sprintf(kubeClustersCreateOutput, f.Name())), strings.TrimSpace(string(output))) | ||
| }) | ||
|
|
||
| it("creates a kube cluster with HA defaulting to true when --ha is omitted", func() { |
Contributor
There was a problem hiding this comment.
Do these integration tests actually create clusters? If so, then let's remove the extra integration tests before merging this PR - we can't afford to e2e or integration test for every combination of cluster fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
--haflag default totruefordoctl kubernetes cluster createwhen creating clustersThis behaviour in DOKS API will be there from version 1.36.0 and later. Hence also merge this during 1.36 doks release
Do not merge
Validations done:
built and validated cluster creation using local ./doctl with and without explicit ha flag.
updated UTs and validated.
go test ./commands/... -run "Kubernetes" -v -count=1
go test ./integration/... -run "TestRun/doctl/kubernetes" -v -count=1