Skip to content

Feature/scatter shot dispersion#36

Merged
jeshernandez merged 5 commits intomainfrom
feature/scatter-shot-dispersion
Mar 13, 2026
Merged

Feature/scatter shot dispersion#36
jeshernandez merged 5 commits intomainfrom
feature/scatter-shot-dispersion

Conversation

@jeshernandez
Copy link
Copy Markdown
Contributor

@jeshernandez jeshernandez commented Mar 13, 2026

Description

  • Added shot dispersion chart, compare against previous shots
  • Added club-level 95% covariance ellipse overlays and labels above each ellipse with averages for TOT, CARRY, HLA, and SPIN

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Physics tuning (changes to rollout/aerodynamic parameters)
  • Documentation update
  • Test improvements

Physics Changes (if applicable)

Modified Parameters

  • Velocity scaling curve
  • Spin multiplier curve
  • COR (Coefficient of Restitution)
  • Surface friction coefficients
  • Aerodynamic coefficients (Cd/Cl)

Test Results

Chip shot:    X.X / X.X yd  (baseline: 7.6/13.1 yd, target: 13.0 yd)
Bump shot:    X.X / X.X yd  (baseline: 38.1/89.7 yd, target: 85 yd)
Wood shot:    X.X / X.X yd  (baseline: 121.7/194.7 yd, target: 198 yd)
Approach shot: X.X / X.X yd  (baseline: 105.6/108.3 yd, target: 108 yd)

Formula Tests

  • Rollout physics tests passing: dotnet test --filter "Category=RolloutPhysics"
  • Updated test expected values (if formulas changed)
  • Updated regression baselines in ShotDistanceRegressionTests.cs

Testing Checklist

  • All tests pass locally: dotnet test OpenFairway.sln
  • Rollout physics formula tests pass: dotnet test --filter "Category=RolloutPhysics"
  • Code builds without errors: dotnet build OpenFairway.sln
  • Tested in Godot editor (if applicable)
  • Manual testing performed (describe in comments below)

Code Quality

  • Code follows project conventions (PascalCase for public, _camelCase for private)
  • Added/updated XML documentation comments for public APIs
  • No compiler warnings introduced
  • Code formatted with dotnet format (will be checked by CI)

Additional Notes

Related Issues

Closes #

@jeshernandez jeshernandez merged commit 14a1cd4 into main Mar 13, 2026
7 checks passed
@jeshernandez jeshernandez deleted the feature/scatter-shot-dispersion branch March 13, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant