Skip to content
This repository was archived by the owner on Jun 27, 2024. It is now read-only.

Tweaking things to work with LSL Forge files#17

Open
furroy wants to merge 1 commit intodigitalfiz:masterfrom
furroy:master
Open

Tweaking things to work with LSL Forge files#17
furroy wants to merge 1 commit intodigitalfiz:masterfrom
furroy:master

Conversation

@furroy
Copy link

@furroy furroy commented Nov 13, 2016

Recognizes .lslp and .lslm files as LSL
Syntax highlights $import, $module and //pragma inline

Recognizes .lslp and .lslm files as LSL
Syntax highlights $import, $module and //pragma inline
@digitalfiz
Copy link
Owner

I will pull this down and test it out tonight and get it merged. Thanks for the contribution!

@furroy
Copy link
Author

furroy commented Nov 14, 2016

cool. i've made a package to hook into LSL Forge from atom since eclipse is such total bloatware. let me know if you're interested.

'name': 'punctuation.definition.comment.lsl'
'match': '(//).*$\\n?'
'name': 'comment.line.double-slash.lsl'
'pragma_inline':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@furroy I don't understand the changes you propose here.

One the one hand you suggest captures groups for the match for pragma_inline, on the other you assign the whole match a scope name. Additionally your regex doesn't have groups at all, so referencing a captures: 1: ... group doesn't make sense.

Same with modules.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tweaked similar examples I found online and worked for me. Maybe they don't follow some sort of best practices, but I've not had any issues with these changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments