1166 local plans dataset list deploy to production

[pooleycodes]

Description

Please replace this line with a brief description of the changes made.

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update

Related Tickets & Documents

• Closes #

QA Instructions, Screenshots, Recordings

Before

Before screenshot here

After

After screenshot here

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

• Yes
• No, and this is why: Please replace this line with details on why tests have not been included
• I need help with writing tests

QA sign off

• Code has been checked and approved
• Design has been checked and approved
• Product and business logic has been checked and proved

[optional] Are there any post-deployment tasks we need to perform?

[optional] Are there any dependencies on other PRs or Work?

Summary by CodeRabbit

• New Features
  • Added support for four new plan-related datasets: plan-timetable, local-plan, minerals-plan, and waste-plan. Each dataset includes associated guidance documentation to assist users in accessing and understanding the data specifications.
  • Enabled local-planning-group as a recognised organisation type in both production and staging environments, expanding the range of organisation categories supported by the system.

[coderabbitai]

Walkthrough

Configuration updates across three environment files add four new dataset configurations (plan-timetable, local-plan, minerals-plan, waste-plan) to default settings, and introduce local-planning-group as a recognised organisation type in both production and staging environments.

Changes

Cohort / File(s)	Summary
Dataset Configurations config/default.yaml	Added four new dataset entries under checkService.contact.issues.datasetsConfig, all pointing to /guidance/specifications/plan guidance with plan as the entity display variable.
Organisation Types config/production.yaml, config/staging.yaml	Added local-planning-group to the organisationTypes list in both production and staging configurations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• Updated hard code list and turn on non auth pages #1149: Adds new hard-coded dataset entries to datasetsConfig in config/default.yaml, targeting the same configuration section.
• changed organisationtypes derivation #1167: Modifies organisationTypes configuration across multiple environments, including adjustments to local-planning-group placement.

Suggested reviewers

• Ben-Hodgkiss

Poem

🐰 Four plans hop into the datasetsConfig warren,
Guidance paths marked with /plan in tow,
While local-planning-groups join the organisationTypes parade,
Production and staging align in harmony below,
Configuration bunny stamps approval with a knowing grin! 📋✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title references the main change (local plans dataset list) and deployment context (production), which aligns with the changeset's additions to dataset configurations and production settings.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 1166-local-plans-dataset-list---deploy-to-production

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	66.03%	6858 / 10385
🔵	Statements	66.03%	6858 / 10385
🔵	Functions	63.59%	276 / 434
🔵	Branches	78.05%	914 / 1171

File Coverage

No changed files found.

Generated in workflow #1369 for commit 016e718 by the Vitest Coverage Report Action

[coderabbitai]

🧹 Nitpick comments (1)

config/default.yaml (1)

136-139: Consider adding local-planning-group to default configuration.

The organisationTypes list in default.yaml does not include local-planning-group, which was added to both config/production.yaml and config/staging.yaml. This creates an inconsistency where development environments (using default.yaml) won't recognise local-planning-group organisations, whilst production and staging will.

Based on the middleware code in organisations.middleware.js, the SQL query dynamically filters organisations using these types, so local-planning-group entries will be excluded in development. Consider whether development and testing environments should also support this organisation type to maintain consistency and enable proper testing before deployment.

♻️ Proposed addition to align with production and staging

 organisationTypes:
   - local-authority
   - national-park-authority
   - development-corporation
+  - local-planning-group

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@config/default.yaml` around lines 136 - 139, The default configuration's
organisationTypes list is missing the local-planning-group entry which causes
dev environments to behave differently than staging/production; update the
organisationTypes YAML sequence by adding "local-planning-group" to the list so
it matches the other environment configs and ensure the middleware that filters
by organisationTypes (organisationTypes key used by organisations.middleware.js)
will include those organisations during development and testing.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@config/default.yaml`:
- Around line 136-139: The default configuration's organisationTypes list is
missing the local-planning-group entry which causes dev environments to behave
differently than staging/production; update the organisationTypes YAML sequence
by adding "local-planning-group" to the list so it matches the other environment
configs and ensure the middleware that filters by organisationTypes
(organisationTypes key used by organisations.middleware.js) will include those
organisations during development and testing.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e2df5b72-7594-4e03-a5f2-3d197252ac5e

📥 Commits

Reviewing files that changed from the base of the PR and between 99d0d8a and 016e718.

📒 Files selected for processing (3)

• config/default.yaml
• config/production.yaml
• config/staging.yaml