Open
Conversation
added description for Daml and Canton
Author
|
@garyverhaegen-da can you review or assign someone to review? thanks. |
I'm sorry I don't have any context here. What is this repo, and why am I involved? |
Author
|
It's the DA orga readme. I made some basic updates. Not sure who has merge rights. |
Comment on lines
+9
to
+11
| [Daml](https://github.com/digital-asset/daml) is an open-source smart contract language for building future-proof distributed applications on a safe, privacy-aware runtime. | ||
|
|
||
| [Canton](https://github.com/digital-asset/canton) is a Daml ledger interoperability protocol. |
There was a problem hiding this comment.
This is not an accurate description of the repositories. I think I'd go more for something like:
Suggested change
| [Daml](https://github.com/digital-asset/daml) is an open-source smart contract language for building future-proof distributed applications on a safe, privacy-aware runtime. | |
| [Canton](https://github.com/digital-asset/canton) is a Daml ledger interoperability protocol. | |
| Our primary open-source offering is Daml Open-Source, which is composed of the following components: | |
| * [list of components] | |
| These components are distributed across the following repositories: | |
| * [digital-asset/daml](https://github.com/digital-asset/daml) contains the code for [compiler, IDE, HTTP, Triggers, Script, etc.] | |
| * [digital-asset/canton](https://github.com/digital-asset/canton) contains the code for [participant, sequencer, ...] | |
| For historical reasons, the fully assembled Daml Open-Source distribution is hosted as GitHub Releases on the [digital-asset/daml] repo. Note that this means releases on that repo include artifacts produced from other repositories. |
Author
I didn't know orgs had readmes 🤷♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added description for Daml and Canton