Open
Conversation
luk4s
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_get_headers_from_find_when_404_custom_prefixis currently flaking. It fails fairly consistently, but for inconsistent reasons. Sometimes the actual http response code is 200, sometimes it's 422, sometimes the test raises a NoMethodError.The inconsistency in failure reason is due to the use of
Thread.currentwithout clearing it, causing response state to leak between tests.I'm of the opinion that this is a bug, not just a test flake, because state will also leak between requests and jobs in Rails, so I've implemented ActiveSupport::CurrentAttributes. Rails will clear it automatically between requests/jobs in production, and ActiveSupport is already a transient dependency.
With that out of the way, the test still fails with a NoMethodError. This is resolved by coercing to an array to execute the query.