Skip to content

Conversation

@helios2003
Copy link
Contributor

@helios2003 helios2003 commented Jan 2, 2025

Added a new function named handleBlockedCommand that handles the issue mentioned in #84

Fixes: #84

@netlify
Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for dicedb-playground ready!

Name Link
🔨 Latest commit ddb33d5
🔍 Latest deploy log https://app.netlify.com/sites/dicedb-playground/deploys/67800385197bf00008877a61
😎 Deploy Preview https://deploy-preview-87--dicedb-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@helios2003
Copy link
Contributor Author

@lucifercr07, @KaviiSuri can you please take a look at the PR?

@helios2003
Copy link
Contributor Author

Also is it better to change the function's name from handleInvalidCommand to handleBlockedCommand?

@lucifercr07
Copy link
Contributor

Also is it better to change the function's name from handleInvalidCommand to handleBlockedCommand?

@helios2003 yes please rename the function.

Copy link
Contributor

@lucifercr07 lucifercr07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@helios2003 please fix the build error and a minor comment, else looks good.

@lucifercr07 lucifercr07 merged commit f6bac4d into dicedb:master Jan 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix dice > prompt when unknown commands are triggered on Playground UI

2 participants