Fixes "InvalidParameterException: Log events in a single PutLogEvents request must be in chronological order." and also a race condition#19
Open
almson wants to merge 2 commits intodibog:masterfrom
Conversation
added 2 commits
March 30, 2020 13:43
Base class AppenderBase already uses synchronized methods, so it's not a problem to make other methods synchronized. This greatly simplifies concurrency issues and makes the code simpler. Previously, there was a bug on line 71 of AwsLogAppender.
List of events needs to be sorted by timestamp before sending to CloudWatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of events needs to be sorted by timestamp before sending to CloudWatch.
Base class AppenderBase already uses synchronized methods, so it's not a problem to make other methods synchronized. This simplifies concurrency issues. Previously, there was a bug on line 71 of AwsLogAppender.