Some more performance optimization changes#2
Open
firstuserhere wants to merge 2 commits intodiatkinson:masterfrom
Open
Some more performance optimization changes#2firstuserhere wants to merge 2 commits intodiatkinson:masterfrom
firstuserhere wants to merge 2 commits intodiatkinson:masterfrom
Conversation
Owner
|
First two items seem great (thank you!) I'm a bit worried about (3), since it's ~30% slower on my machine (M1), and seems to display incorrectly, at least on my laptop screen. 
I'm open to adding it as an option, but would prefer to have it disabled by default. How does that sound? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tbd : formatted_next_tokens should be optimized (Currently all tokens would take O(n logn) time) (Use NumPy for Sorting Instead of Python’s sort, minimize string operations, Cache the Output etc).