Merged
Conversation
Co-authored-by: Diego Alvarez S. <dialvarezs@gmail.com>
Co-authored-by: Diego Alvarez S. <dialvarezs@gmail.com>
Co-authored-by: Diego Alvarez S. <dialvarezs@gmail.com>
Co-authored-by: Diego Alvarez S. <dialvarezs@gmail.com>
Co-authored-by: Diego Alvarez S. <dialvarezs@gmail.com>
Co-authored-by: Diego Alvarez S. <dialvarezs@gmail.com>
Fixing the issues with bibliography
Added caching for the Fontist gem to improve installation speed.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps the version from 0.6.0 to 0.6.1, introducing support for dictionary-formatted authors in Hayagriva YAML bibliographies, adding a reverse-order parameter for publications, and optimizing GitHub Actions font caching.
Key Changes:
- Added support for Hayagriva dictionary author format (with "name", "given-name", "prefix" fields)
- Introduced
reverse-orderparameter for publications display - Updated fontawesome dependency from 0.6.0 to 0.6.1
- Optimized GitHub Actions with fontist gem caching
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| typst.toml | Version bump from 0.6.0 to 0.6.1 |
| lib.typ | Added __format-author function for dictionary author support, refactored publication formatting, added reverse-order parameter, updated fontawesome version, added clarifying comments |
| template/publications.yml | Added test publications with dictionary-formatted authors and books without parent field |
| template/cv.typ | Updated import version to 0.6.1 |
| template/letter.typ | Updated import version to 0.6.1 |
| README.md | Updated example code to use version 0.6.1 |
| .github/actions/setup-fonts/action.yml | Added fontist gem caching and conditional gem installation |
Comments suppressed due to low confidence (1)
lib.typ:475
- The highlight-authors matching logic will not work correctly when an author is provided as a dictionary. At this point in the code,
authormay be a dictionary (e.g., with "name", "given-name", "prefix" fields), buthighlight-authorslikely contains string values like "LastName, FirstName". The comparisonauthor in highlight-authorswill never match for dictionary authors. Consider performing the comparison after converting the author to a string format, or convert the author to the string format expected by highlight-authors before the comparison.
if author in highlight-authors {
text(weight: "medium", author-display)
} else {
author-display
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.