DIAOracleV3

.github/workflows/smart-contracts.yml

@@ -0,0 +1,170 @@
+name: smart-contracts
+
+on:
+  pull_request:
+    branches:
+      - master
+      - oraclev3
+    paths:
+      - "contracts/**"
+      - "test-foundry/**"
+      - "foundry.toml"
+      - ".github/workflows/smart-contracts.yml"
+  push:
+    branches:
+      - master
+    paths:
+      - "contracts/**"
+      - "foundry.toml"
+      - ".github/workflows/smart-contracts.yml"
+  workflow_dispatch:
+
+permissions:
+  contents: read
+  security-events: write # required for uploading SARIF to GitHub Security tab
+
+jobs:
+  # ─────────────────────────────────────────────
+  # Job 1: Solidity Linter (solhint)
+  # ─────────────────────────────────────────────
+  solhint:
+    name: Solidity Linter
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Node
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20"
+          cache: "npm"
+          cache-dependency-path: contracts/package-lock.json
+
+      - name: Install dependencies
+        working-directory: contracts
+        run: npm ci
+
+      - name: Run solhint
+        working-directory: contracts
+        continue-on-error: true
+        run: |
+          npx solhint '**/*.sol' \
+            --ignore-path .solhintignore \
+            --formatter stylish
+
+  # ─────────────────────────────────────────────
+  # Job 2: Unit Tests & Coverage
+  # ─────────────────────────────────────────────
+  tests:
+    name: Unit Tests & Coverage
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Install Foundry
+        uses: foundry-rs/foundry-toolchain@v1
+        with:
+          version: stable
+
+      - name: Install Foundry dependencies
+        run: forge install || true
+
+      - name: Install forge-std
+        run: forge install foundry-rs/forge-std --no-git || true
+
+      - name: Setup Node
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20"
+
+      - name: Install OpenZeppelin via npm
+        run: |
+          npm install @openzeppelin/contracts@5.2.0
+          npm install @openzeppelin/contracts-upgradeable@5.2.0
+
+      - name: Write Foundry remappings
+        run: |
+          echo "@openzeppelin/contracts/=node_modules/@openzeppelin/contracts/" > remappings.txt
+          echo "@openzeppelin/contracts-upgradeable/=node_modules/@openzeppelin/contracts-upgradeable/" >> remappings.txt
+          echo "forge-std/=lib/forge-std/src/" >> remappings.txt
+
+      - name: Run tests
+        continue-on-error: true
+        run: forge test -v
+
+      - name: Run coverage
+        continue-on-error: true
+        run: forge coverage
+
+  # ─────────────────────────────────────────────
+  # Job 3: Slither Static Analysis
+  # ─────────────────────────────────────────────
+  slither:
+    name: Slither Analysis
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Install Foundry
+        uses: foundry-rs/foundry-toolchain@v1
+        with:
+          version: stable
+
+      - name: Install Foundry dependencies
+        run: forge install || true
+
+      - name: Setup Node
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20"
+
+      - name: Install OpenZeppelin via npm
+        run: |
+          npm install @openzeppelin/contracts@5.2.0
+          npm install @openzeppelin/contracts-upgradeable@5.2.0
+
+      - name: Remove contracts/node_modules to prevent forge scanning it
+        run: rm -rf contracts/node_modules
+
+      - name: Write Foundry remappings
+        run: |
+          echo "@openzeppelin/contracts/=node_modules/@openzeppelin/contracts/" > remappings.txt
+          echo "@openzeppelin/contracts-upgradeable/=node_modules/@openzeppelin/contracts-upgradeable/" >> remappings.txt
+
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: "3.11"
+
+      - name: Install solc
+        run: |
+          pip install solc-select==1.2.0
+          solc-select install 0.8.29
+          solc-select use 0.8.29
+
+      - name: Install Slither
+        run: pip install slither-analyzer==0.11.5
+
+      - name: Run Slither
+        continue-on-error: true
+        run: |
+          python -m slither contracts/ \
+            --solc-remaps "@openzeppelin/contracts/=node_modules/@openzeppelin/contracts/ @openzeppelin/contracts-upgradeable/=node_modules/@openzeppelin/contracts-upgradeable/" \
+            --filter-paths "contracts/Flattened_for_verification.sol" \
+            --sarif results.sarif
+
+      - name: Ensure SARIF file exists
+        if: always()
+        run: |
+          if [ ! -f results.sarif ]; then
+            echo '{"version":"2.1.0","$schema":"https://json.schemastore.org/sarif-2.1.0.json","runs":[{"tool":{"driver":{"name":"Slither","version":"0.11.5"}},"results":[]}]}' > results.sarif
+          fi
+
+      - name: Upload SARIF to GitHub Security tab
+        uses: github/codeql-action/upload-sarif@v4
+        if: always()
+        with:
+          sarif_file: results.sarif

.gitignore

@@ -3,12 +3,16 @@ decentral-feeder
 decentral-feeder/build/docker-images.sh
 /build/docker-images.sh
 .env
+.env.local
+.deployed_addresses
 lib
 cache
 .vscode
 out
 coverage-report
 lcov.info
 node_modules
+broadcast
 
 
+contracts/node_modules

.gitmodules

@@ -1,3 +1,7 @@
 [submodule "lib/forge-std"]
 	path = lib/forge-std
 	url = https://github.com/foundry-rs/forge-std
+[submodule "lib/openzeppelin-foundry-upgrades"]
+	path = lib/openzeppelin-foundry-upgrades
+	url = https://github.com/OpenZeppelin/openzeppelin-foundry-upgrades
+

.slither.config.json

@@ -0,0 +1,11 @@
+{
+  "detectors_to_exclude": [
+    "uninitialized-state",
+    "timestamp"
+  ],
+  "exclude_informational": false,
+  "exclude_optimization": false,
+  "exclude_low": false,
+  "exclude_medium": false,
+  "exclude_high": false
+}

.solhint.json

@@ -0,0 +1,19 @@
+{
+  "extends": "solhint:recommended",
+  "rules": {
+    "no-global-import": "off",
+    "compiler-version": ["error", "^0.8.29"],
+    "max-line-length": ["warn", 120],
+    "func-name-mixedcase": "warn",
+    "func-param-name-mixedcase": "warn",
+    "modifier-name-mixedcase": "warn",
+    "private-vars-leading-underscore": "warn",
+    "use-forbidden-name": "warn",
+    "var-name-mixedcase": "warn",
+    "no-console": "off",
+    "no-empty-blocks": "warn",
+    "no-unused-vars": "warn",
+    "func-visibility": ["warn", { "ignoreConstructors": true }],
+    "one-contract-per-file": "off"
+  }
+}

.solhintignore

@@ -0,0 +1,7 @@
+contracts/Flattened_for_verification.sol
+**/node_modules/**/*.sol
+**/lib/**/*.sol
+**/out/**/*.sol
+**/cache/**/*.sol
+test-foundry/**/*.sol
+contracts/node_modules/**/*.sol

contracts/.solhintignore

@@ -0,0 +1,2 @@
+Flattened_for_verification.sol
+node_modules/