Replace Zend_Db_Table_Rowset docblocks with generics to allow better type hinting#116
Open
tomasfejfar wants to merge 1 commit intodiablomedia:masterfrom
Open
Replace Zend_Db_Table_Rowset docblocks with generics to allow better type hinting#116tomasfejfar wants to merge 1 commit intodiablomedia:masterfrom
tomasfejfar wants to merge 1 commit intodiablomedia:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
=========================================
Coverage 55.26% 55.26%
Complexity 1722 1722
=========================================
Files 42 42
Lines 4706 4706
=========================================
Hits 2601 2601
Misses 2105 2105
Continue to review full report at Codecov.
|
Member
|
@tomasfejfar we actually don't use the Zend_Db component in our apps, so I don't think I'm the best person to get feedback from on this :) I'm open to merging changes once you're happy with it though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PoC, that's still somewhat limited due to phpstan/phpstan#5817 but I got the rest working in tomasfejfar/phpstan-zf1#2.
Do you like the way this is heading? I wonder if this is the right way and wanted to get some feedback early.