Add support for second language #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvyad
reviewed
Jul 12, 2025
|
|
||
|
|
||
| ## Usage | ||
| To start transcription, press and hold the registered hotkey to start recording. To stop the recording, lift your registered hotkey. On macOS, the registered hotkey is the globe icon by default. For other operating systems, this will have to by manually configured in `main.py` as described earlier. |
Owner
There was a problem hiding this comment.
Please add back the usage section.
dhruvyad
reviewed
Jul 12, 2025
| transcriber = WhisperAPITranscriber.create() | ||
| # Set initial language from environment variable if provided | ||
| initial_language = os.getenv('UTTERTYPE_LANGUAGE', 'en') | ||
| transcriber.set_language(initial_language) |
Owner
There was a problem hiding this comment.
Would prefer if this is done in the APITranscriber class itself to keep main.py simple. One of the goals of the repo is also to keep things extremely readable, especially main.py.
dhruvyad
reviewed
Jul 12, 2025
| print(f"UtterType started with dual language support") | ||
| print(f"Primary language ({primary_lang.upper()}): {primary_key}") | ||
| print(f"Secondary language ({secondary_lang.upper()}): {secondary_key}") | ||
| print("Hold the respective hotkey to record in the corresponding language") |
Owner
There was a problem hiding this comment.
Could you also move these print statements and env fetches somewhere else? Perhaps in the default transcriber class?
Owner
|
Thanks for contributing to uttertype! Left some comments regarding style and some doc updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for recording speech in two languages using separate hotkeys.
Configuration