adding "only_path" to url_for calls in init.rb to return relative URL and omit protocol. This is due to issue #6 (https://github.com/dhanasingh/redmine_wktime/issues/6), where an error is reported that http content cannot be loaded over https.#9
Conversation
… and omit protocol
ghost
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds "only_path" to url_for() calls in init.rb so that a relative URL (with protocol omitted) is returned. Without this fix, the URL returned is http, even though Redmine is run over https, and even though the protocol in Administration -> Settings is set to https. So this fix will honor what is configured by the site. Without this fix, in Chrome the spinner never disappears when viewing tickets because that error causes the ajax request to never 'complete'.
This was raised by issue #6