Merged
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small PR should increase test coverage to 100%. This is done in three main ways:
AcquisitionStage._should_skip_extraction()andAcquisitionStage._extract_zip()to cover handling of exceptions and edge cases.main()ingeoparser/__main__.pyvia subprocess. Because this cannot be tracked by coverage in the parent process, the line is excluded from coverage nonetheless.loader.py) are also excluded. These exception handlers guard against SQLite-internal failures. This allows us to exclude them in my opinion, as mocking such exceptions is a bit out of scope for this Python test suite. Feel free to challenge.