Draft
Conversation
Author
|
Perhaps due to version upgrade of threejs the roughnessMap is not part of the MeshPhongMaterial, commented that out. Transformed couple of async assets loading to be loaded parallel instead of awaiting sequential loads. Promise.all is used in that regard as all assets are expected to be loaded successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some context here: #32
I would have liked to spend some more time with this but unfortunately I'm quite occupied elsewhere and wanted to make this PR as this could work as ground work for more optimal TypeScript Port and perhaps even get the advantages of the most recent Threejs version (read TSL).
What has been done:
Directly converted to TypeScript and pumped package versions. Roughly tested manually and everything seems to work.
Packaging needs to be fixed though.
If accepted, I'd propose that 'typescript' branch is created of this to allow addressing the packaging related issues. Perhaps also for migration to vite 8 and Threejs' just release major update?