-
Notifications
You must be signed in to change notification settings - Fork 36
Python27 support #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Python27 support #19
Conversation
|
fixes issue #15 |
|
Updated with the recommendations, except for two things.
I found that nosetests swallows any print statements by default, except if you use the '-s' or '--nocapture' option. The following gist shows the results of the tests. https://gist.github.com/chorejasbob/890137b096ffae50dc86158d60c0c062 |
…ted with import recommendation.
Python 2.7 tests passing:
`(venv)$ python --version
Python 2.7.16
(venv)$ nosetests -v tests/test_JMXQuery.py
tests.test_JMXQuery.test_wildcard_query ... ok
tests.test_JMXQuery.test_kafka_plugin ... ok
This test is to check that we don't get any threading issues as the module will be ... ok
Ran 3 tests in 9.018s
OK
`
Python 3.6 tests passing:
`(venv)$ source ../venv3/bin/activate
(venv3)$ python --version
Python 3.7.3
(venv3)$ nosetests -v tests/test_JMXQuery.py
tests.test_JMXQuery.test_wildcard_query ... ok
tests.test_JMXQuery.test_kafka_plugin ... ok
This test is to check that we don't get any threading issues as the module will be ... ok
Ran 3 tests in 8.689s
OK
`