Skip to content

Make json decoding not strict. JMX sometimes throws control characters #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Matthew-Jenkins wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make json decoding not strict. JMX sometimes throws control characters #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion python/jmxquery/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ class MetricType(Enum):
COUNTER = 'counter'
GAUGE = 'gauge'

class NotStrictJSONDecoder(json.JSONDecoder):
def __init__(self, strict=False, *args, **kwargs):
json.JSONDecoder.__init__(self, strict=False, *args, **kwargs)

class JMXQuery:
"""
A JMX Query which is used to fetch specific MBean attributes/values from the JVM. The object_name can support wildcards
Expand Down Expand Up @@ -177,7 +181,7 @@ def __load_from_json(self, jsonOutput: str) -> List[JMXQuery]:
:param jsonOutput: The JSON Array returned from the command line
:return: An array of JMXQuerys
"""
jsonMetrics = json.loads(jsonOutput)
jsonMetrics = json.loads(jsonOutput, cls=NotStrictJSONDecoder)
metrics = []
for jsonMetric in jsonMetrics:
mBeanName = jsonMetric['mBeanName']
Expand Down