work from #66
work from #66
Conversation
We want `dataclass_csv2` on pypi but keep `dataclass_csv` to be a drop-in replacement.
taken from https://github.com/pypa/distutils/blob/ff11eed0c36b35bd68615a8ebf36763b7c8a6f28/distutils/util.py#L321 Fix dfurtado#52 Note that the utility of the use of this function has not been checked, a better refactor may be possible.
reimplement dfurtado#57
…rg used in classmethods
reimplement and close dfurtado#61
The whole code would probably need to be refactored but it should works for now ``` dataclass-csv2/dataclass_csv/dataclass_reader.py:149:76 - error: "key" is possibly unbound (reportPossiblyUnboundVariable) ```
|
Hey @kraktus thank you so much for putting this together! Awesome additions! 👍🏽 The GitHub actions for testing the code using multiple Python versions was great! Exactly what I had in mind! The usage of I will make sure to add you to the list of contributors. I will see what I can do to fix all the conflicts and get that merged asap. Thank you! |
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"] |
There was a problem hiding this comment.
That's great! Exactly what I was going to do. 👍🏽
| { url = "https://files.pythonhosted.org/packages/d1/d6/3965ed04c63042e047cb6a3e6ed1a63a35087b6a609aa3a15ed8ac56c221/colorama-0.4.6-py2.py3-none-any.whl", hash = "sha256:4f1d9991f5acc0ca119f9d443620b77f9d6b33703e51011c16baf57afb285fc6", size = 25335, upload-time = "2022-10-25T02:36:20.889Z" }, | ||
| ] | ||
|
|
||
| [[package]] |
There was a problem hiding this comment.
I regenerated the lock file, and I noticed that the project has a dependency to itself. Can I remove this?
| ## Thanks | ||
|
|
||
| Thank you to all the amazing contributors who have supported this project over the years, with special thanks to [@kraktus](https://github.com/kraktus) for setting up GitHub Actions, improving automation for package creation, and making numerous code enhancements. | ||
|
|
There was a problem hiding this comment.
Noted your work here, I hope it is ok.
2 participants
Hello,
A PR that show the changes made in https://github.com/kraktus/dataclass-csv2, for reference. I have no time nor desire to fix the merge issues, but feel free to do so.