Skip to content

Conversation

@m-dzianishchyts
Copy link
Contributor

@m-dzianishchyts m-dzianishchyts commented Oct 15, 2025

What does this PR do?

  • Fixes PathHandler tests that were failing on Windows.
  • Adds windows-latest to CI to catch Windows-specific issues early.

@m-dzianishchyts
Copy link
Contributor Author

Could someone please rerun checks? I believe this is an another accidental fall for no known reason yet.

BTW, the end of Java 11 support is coming. I'm wondering if JJava should drop its support anytime soon.

@m-dzianishchyts m-dzianishchyts marked this pull request as ready for review October 15, 2025 13:59
@andrus
Copy link
Contributor

andrus commented Oct 15, 2025

Restarted. FWIW, the failure was on java 21.

End of Java 11 support is only about the Oracle distro (that almost nobody is using). I think it is reasonable to keep supporting Java 11 for the kernel for a few more years. Perhaps, we'll bump it up to 21 in JJava 2.0

@andrus
Copy link
Contributor

andrus commented Oct 15, 2025

And now it failed on Windows.

@m-dzianishchyts
Copy link
Contributor Author

Unfortunately, Testcontainers does not support the windows-latest runner with its windows containers. The workaround will most likely require a custom runner image, so it's better to just disable the appropriate tests for Windows.

@m-dzianishchyts m-dzianishchyts marked this pull request as draft October 24, 2025 08:44
@m-dzianishchyts m-dzianishchyts changed the title Fix PathHandler tests Several CI fixes Oct 24, 2025
@stariy95
Copy link
Member

Hm, one task is already running for more than hour, seems like something is still wrong: https://github.com/dflib/jjava/actions/runs/18777118744/job/53574198684?pr=98

@m-dzianishchyts m-dzianishchyts force-pushed the fix-win-tests branch 2 times, most recently from ce74521 to 923d637 Compare October 24, 2025 12:30
@m-dzianishchyts m-dzianishchyts marked this pull request as ready for review October 24, 2025 12:36
@m-dzianishchyts m-dzianishchyts marked this pull request as draft October 24, 2025 13:06
@m-dzianishchyts m-dzianishchyts marked this pull request as ready for review November 6, 2025 11:37
@m-dzianishchyts m-dzianishchyts changed the title Several CI fixes Run tests on Windows Dec 5, 2025
Add windows-latest strategy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants