refactor: Encapsulate NetworkTopology#8828
Open
schneiderstefan wants to merge 2 commits intomasterfrom
Open
Conversation
This commit makes NetworkTopology::subnets and NetworkTopology::routing_table private and provides a public getter as well as a test-only setter and mutable getter. The goal is to encapsulate these fields with an eye of supporting engines, where depending on the call site engines have to be handled differently. Encapsulation makes it easier to keep an eye on all relevant call sites and decisions wrt engines. Other fields in the network topology remain public for simplicity. They can be encapsulated in a similar fashion when a need arises.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes NetworkTopology::subnets and
NetworkTopology::routing_table private and provides a public getter as well as a test-only setter and mutable getter.
The goal is to encapsulate these fields with an eye of supporting engines, where depending on the call site engines have to be handled differently. Encapsulation makes it easier to keep an eye on all relevant call sites and decisions wrt engines.
Other fields in the network topology remain public for simplicity. They can be encapsulated in a similar fashion when a need arises.